Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s deps to 1.27 #608

Merged
merged 8 commits into from
Aug 5, 2023
Merged

Conversation

Huang-Wei
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • bump go version to 1.20
  • bump k8s version to 1.27
  • bump controller-runtime to 0.15

Which issue(s) this PR fixes:

Fixes #606

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump go version to 1.20 and k8s deps to 1.27

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@Huang-Wei
Copy link
Contributor Author

@zwpaper you can take over if you have bandwidth.

Atop this PR, UT in pkg/controllers/elasticquota_controller_test.go failed. I haven't have cycle to look into it yet.

@zwpaper
Copy link
Member

zwpaper commented Jul 28, 2023

added a PR here Huang-Wei#1 to fix the failing test.

will do a full test later @Huang-Wei

@Huang-Wei
Copy link
Contributor Author

Huang-Wei commented Jul 28, 2023

added a PR here Huang-Wei#1 to fix the failing test.

Thanks a lot! I've merged that one in the fork repo, and push here.

I'm going to tweak the CI to use go 1.20, and then have the CI start here: kubernetes/test-infra#30235

@Huang-Wei Huang-Wei marked this pull request as ready for review July 28, 2023 20:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from seanmalloy July 28, 2023 20:40
@Huang-Wei
Copy link
Contributor Author

/retest

@Huang-Wei
Copy link
Contributor Author

CI failure:

--- FAIL: TestCapacityScheduling (34.38s)
    capacity_scheduling_test.go:59: The CRD is ready to serve
    capacity_scheduling_test.go:87: Init scheduler success
    --- FAIL: TestCapacityScheduling/cross-namespace_preemption (10.32s)
        capacity_scheduling_test.go:553: cross-namespace preemption Waiting expectedPods error: timed out waiting for the condition
    --- FAIL: TestCapacityScheduling/in-namespace_preemption (10.32s)
        capacity_scheduling_test.go:553: in-namespace preemption Waiting expectedPods error: timed out waiting for the condition
    --- FAIL: TestCapacityScheduling/cross-namespace_preemption_with_three_elasticquota (10.40s)

@Huang-Wei
Copy link
Contributor Author

@zwpaper ^^ FYI

@zwpaper
Copy link
Member

zwpaper commented Aug 4, 2023

really strange, we did not change the logic related to the integration test, why is this keep failing and the origin tests work fine #610

it keeps report

E0804 15:56:02.187916   55780 framework.go:716] "Failed running RemovePod on PreFilter plugin" err="error reading \"PreFilterInterPodAffinity\" from cycleState: not found" plugin="InterPodAffinity" pod="ns2/t1-p5"

@zwpaper
Copy link
Member

zwpaper commented Aug 4, 2023

/test pull-scheduler-plugins-integration-test-master

@Huang-Wei
Copy link
Contributor Author

it keeps report

E0804 15:56:02.187916   55780 framework.go:716] "Failed running RemovePod on PreFilter plugin" err="error reading > \"PreFilterInterPodAffinity\" from cycleState: not found" plugin="InterPodAffinity" pod="ns2/t1-p5"

@zwpaper I also spot this while debugging. I'm pretty sure it's a regression introduced in upstream v1.27. Let me file a fix in k/k.

@Huang-Wei
Copy link
Contributor Author

@zwpaper to unblock bumping master to 1.27, I commented out those preemption tests. We can revert them once the upstream fix is available in the next v1.27 patch release. PTAL.

@zwpaper
Copy link
Member

zwpaper commented Aug 5, 2023

wow, I have tried and did not found that changes, let me have a look at the k/k issue and find out is there anything I can help.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit efddd13 into kubernetes-sigs:master Aug 5, 2023
@Huang-Wei Huang-Wei deleted the bump-k8s-1.27 branch August 5, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller-runtime version 0.14.X incompatible with client-go 0.27
3 participants